adblock-resources icon indicating copy to clipboard operation
adblock-resources copied to clipboard

Published 20 hours ago • verified publisher icon brave

Add `npm run verify` as a git commit hook

Open pes10k opened this issue 4 years ago • 6 comments

Just to ensure that we never wind up with bad json here, and potentially breaking the DAT, WDYT of adding npm run verify as a commit hook?

pes10k avatar May 31 '20 00:05 pes10k

@antonok-edm ^^^

pes10k avatar May 31 '20 00:05 pes10k

I was hoping it could be added as a CI step eventually. I guess a hook would work too, but as far as I'm aware hooks can only be added manually on the client side.

antonok-edm avatar May 31 '20 00:05 antonok-edm

As of #4, this is becoming increasingly necessary.

antonok-edm avatar Jul 20 '20 19:07 antonok-edm

Is anyone working on this?

What do you have in mind, a manual set up at post-install and .git/hooks or something like husky?

myreli avatar Nov 16 '20 22:11 myreli

@myreli nobody's working on it at the moment, although we are happy to accept PRs :smile:.

Leveraging npm install in some way to setup a git hook sounds like an excellent idea!

antonok-edm avatar Nov 17 '20 21:11 antonok-edm

@antonok-edm cool! I will start working on it them :grin:

myreli avatar Nov 18 '20 00:11 myreli