adblock-lists icon indicating copy to clipboard operation
adblock-lists copied to clipboard
verified publisher icon brave

youtube quality android

Open tapanmodh opened this issue 1 year ago • 4 comments

Related to issue: https://github.com/brave/brave-browser/issues/32842 Brave-core PR: https://github.com/brave/brave-core/pull/24164 Adblock-resource PR: https://github.com/brave/adblock-resources/pull/196

tapanmodh avatar Aug 06 '24 20:08 tapanmodh

This rule will apply immediately across all Brave versions, whereas https://github.com/brave/brave-core/pull/24164 will only go into Nightly. Is that the intention?

ShivanKaul avatar Aug 13 '24 03:08 ShivanKaul

This rule will apply immediately across all Brave versions, whereas brave/brave-core#24164 will only go into Nightly. Is that the intention?

Is it? We need it with brave/brave-core#24164 as this PR handles settings for that. Can we apply this rule to only Nightly first?

tapanmodh avatar Aug 13 '24 08:08 tapanmodh

Maybe apply to specifically m.youtube.com to limit the scope to mobile only

ryanbr avatar Aug 26 '24 06:08 ryanbr

Can we apply this rule to only Nightly first?

There's no way to apply a filter rule to a particular channel. You could however create a new list and enable it on Nightly via Griffin, see: https://github.com/brave/brave-core/pull/22858/files This issue captures the series of steps for introducing a new list, adding it to the filter catalog, and selectively turning it on in a specific channel: https://github.com/brave/brave-browser/issues/36244

ShivanKaul avatar Aug 26 '24 17:08 ShivanKaul