bat-ledger

bat-ledger copied to clipboard

After we sign the ads grants and upload to the ledger, we need to enter the transactions to show that we've sent the BAT to the wallets to avoid double...

nvonpentz

Rename twitch publishers to author instead of channel

1

in some places we use `twitch#author` however we should be using `twitch#channel` everywhere

maikelmclauflin

migrate eyeshade collections to postgres

1

evq

`process.env` reading and transforming should be centralized to `config.js` or another aptly named file to separate environment from usage and simplify inputs and reduce mutability.

maikelmclauflin

WHY logic for queue setup should exist in redis using a package like `bee-queue` WHERE install the package as a dependency and utilize it in the worker files and other...

maikelmclauflin

add typescript to eyeshade

1

some changes will be implemented in ledger with the next round of directions. eyeshade and bat-utils should stay pretty similar, so it is a good place to start integrating typescript.

maikelmclauflin

maikelmclauflin

maikelmclauflin

errors on insertion are not captured with adequate granularity. validating and catching in a single function (insertTransaction) would avoid redundancy and keep concerns separate. https://papertrailapp.com/groups/6581022/events?focus=1052348710581346312 https://sentry.io/organizations/brave-software/issues/978863742/?project=225111&referrer=slack&statsPeriod=14d

maikelmclauflin

instrument referral finalization count on eyeshade

6

We occasionally have publishers report that their balance hasn't increased but their confirmations have. In addition we have evidence that confirmations haven't properly updated publisher's balances in the past. There's...

corymcdonald