bat-go

bat-go copied to clipboard

Ensure KMS key alias creation is atomic

1

in the future case where we are running multiple instances of the enclave, it's possible there is a race whereby both enclaves create a new key. there needs to be...

evq

Validate claims logic has been updated by Zebpay API server

2

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494021429 See https://bravesoftware.slack.com/archives/C04H4PJFMPG/p1698101819640059 for additional details

kdenhartog

If you bottstrap twice and then try to take an action that combines the cached shares you can hit a combination error that is the result of having duplicate shares....

Sneagan

Improve Error Management of the Client HTTP Implementation

1

> would it not make more sense to handle all the code mapping here so that we may cleanly map to an enum of statuses and only return error if...

Sneagan

Operator shares should be bumped to 2 in the calling function

2

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494191389 Alternatively, if we expect this to be globally set we could set this inside the function rather than having the caller pass it in.

kdenhartog

fix or remove HTTP Signatures tests that are commented out

1

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494028234 Test is [here](https://github.com/brave-intl/bat-go/blob/nitro-payments-dev/libs/httpsignature/httpsignature_test.go#L679)

kdenhartog

Once an error occurs, `lastError` should not be make `null` later. The most easy to reproduce case here is after the first authorization. Basically all transactions should at least have...

Sneagan

remove QLDB hash verification code

1

evq

``` {"level":"fatal","error":"could not create kms secret encryption key: failed to match policy text","time":"2024-03-21T13:16:43Z","message":"failed to initialize payments service"} ``` When this happens, a reboot of the pod will clear it. The...

Sneagan

Remove unused state machines

1

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494179820 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494180075 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494160407 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494196522 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494196854 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494197039 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494198396 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494198953

kdenhartog