bat-go

bat-go copied to clipboard

Currently we're referencing the Transaction Authorization key list for all endpoints. These should be split into separate lists that are logically distinct so we can make sure the secrets managers...

kdenhartog

Right now, we need to use `disaster` to download and then manually encrypt and re-upload chain keys. This might be able to completed alongside #2486.

Sneagan

Right now, we download the secrets file before fetching shares. This means that decryption will always fail in cases where we are creating a new vault if the steps are:...

Sneagan

Add Idempotency Key Namespace UUID Validation

3

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494164076 Additionally according to [the docs](https://pkg.go.dev/github.com/google/uuid#MustParse) this would panic if this is an invalid UUID. Do we want that to occur? That seems like it could lead to an unintentional...

kdenhartog

We should consider a mechanism for tombstoning old vaults to prevent their use. We need to consider things like prior wallet draining and secret rotation as part of this. _Originally...

Sneagan

Move Away from using Environment Variables for Secrets

3

Instead of [setting environment variables](https://github.com/brave-intl/bat-go/blob/nitro-payments-dev/services/payments/secrets.go#L165) to contain the secrets, put them into the application context and make them available where used.

husobee

Remove support for unnecessary algorithms in libs/nitro/pkcs7 directory

2

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494038229 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494038272 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494038647 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494040006 https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494040716 Do we need all of these algorithms to be supported? It seems like many of them would be unnecessary and in some cases some of...

kdenhartog

Do we intend to still use the `/v1/payments/{documentID}/status` endpoint?

1

https://github.com/brave-intl/bat-go/pull/1691

kdenhartog

Integrate work to date to perform end to end "dry run" settlement test

4

**Test 0: KMS key policy idempotency** **Test 1: Worker hitting stub prepare / submit endpoints** Remaining work: - [x] Do the test using the `nitro-payments-dev` branch ( should already have...

evq

validate logic should be re-enabled in authorize payments CLI command

1

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494204972

kdenhartog