bat-go icon indicating copy to clipboard operation
bat-go copied to clipboard

Resolve conflicts with `master`

Open Sneagan opened this issue 11 months ago • 3 comments

Summary

Type of Change

  • [ ] Product feature
  • [ ] Bug fix
  • [ ] Performance improvement
  • [ ] Refactor
  • [ ] Other

Tested Environments

  • [ ] Development
  • [ ] Staging
  • [ ] Production

Before Requesting Review

  • [ ] Does your code build cleanly without any errors or warnings?
  • [ ] Have you used auto closing keywords?
  • [ ] Have you added tests for new functionality?
  • [ ] Have validated query efficiency for new database queries?
  • [ ] Have documented new functionality in README or in comments?
  • [ ] Have you squashed all intermediate commits?
  • [ ] Is there a clear title that explains what the PR does?
  • [ ] Have you used intuitive function, variable and other naming?
  • [ ] Have you requested security and/or privacy review if needed
  • [ ] Have you performed a self review of this PR?

Manual Test Plan

Sneagan avatar Mar 21 '24 16:03 Sneagan

A few PRs for Ntiro have been closed recently. Should this one follow the same path? @Sneagan

pavelbrm avatar Jun 05 '24 07:06 pavelbrm

Is this still relevant? Or can we close or mark as draft please to remove from our needs-review lists?

tackley avatar Aug 21 '24 20:08 tackley

@tackley I believe this is not relevant anymore, but will leave the decision to @Sneagan.

pavelbrm avatar Aug 22 '24 07:08 pavelbrm