bat-go icon indicating copy to clipboard operation
bat-go copied to clipboard

Published 20 hours ago • verified publisher icon brave-intl

validate logic should be re-enabled in authorize payments CLI command

Open kdenhartog opened this issue 1 year ago • 1 comments

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494204972

kdenhartog avatar Feb 22 '24 13:02 kdenhartog

https://github.com/brave-intl/bat-go/blob/master/tools/payments/cmd/validate/main.go#L87-L93 is being removed in the nitro-payments-dev branch which is what performs the nitro attestation validation to confirm we're running in the nitro enclave properly via the CLI.

If we remove this call in the nitro-payments-dev branch then we need to re-add it back in.

kdenhartog avatar May 02 '24 04:05 kdenhartog

Looks like this is just called from the git go when a new payments CLI client is created which is used in every command. This can be closed.

kdenhartog avatar May 24 '24 13:05 kdenhartog