Operator shares should be bumped to 2 in the calling function

[kdenhartog]

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494191389

Alternatively, if we expect this to be globally set we could set this inside the function rather than having the caller pass it in.

[Sneagan]

This check should be removed entirely. Instead, we should be handling the case where the subsequent shamir.Combine call failed due to insufficient or duplicate shares. Add wrapped error or decorator(s) as needed.

[kdenhartog]

This seems like one of those issues that is a "nice to have" based on our operators policy currently, but I'd rather get this stabilized before we need it so marking it as blocking.

[ibukanov]

@kdenhartog On my current branch for localdev I refactored the code to make fetching of secretes and operator shares independent. It also makes handling of number of shares more explicit similarly to your PR but it conflicts badly with your PR. I think we should ping @Sneagan to have your changes land and then I will address the conflicts.

[kdenhartog]

That sounds like a good plan to me. I've marked that PR as ready since I just realized I left it in draft.