Nitro Payments

[husobee]

Summary

Includes commits from following PRs: https://github.com/brave-intl/bat-go/pull/1387 https://github.com/brave-intl/bat-go/pull/1385 https://github.com/brave-intl/bat-go/pull/1384 https://github.com/brave-intl/bat-go/pull/1219

Type of change ( select one )

• [ ] Product feature
• [ ] Bug fix
• [ ] Performance improvement
• [ ] Refactor
• [ ] Other

Tested Environments

• [ ] Development
• [ ] Staging
• [ ] Production

Before submitting this PR:

• [ ] Does your code build cleanly without any errors or warnings?
• [ ] Have you used auto closing keywords?
• [ ] Have you added tests for new functionality?
• [ ] Have validated query efficiency for new database queries?
• [ ] Have documented new functionality in README or in comments?
• [ ] Have you squashed all intermediate commits?
• [ ] Is there a clear title that explains what the PR does?
• [ ] Have you used intuitive function, variable and other naming?
• [ ] Have you requested security / privacy review if needed
• [ ] Have you performed a self review of this PR?

Manual Test Plan:

[DJAndries]

@husobee Any updates on this by chance? Would be nice to see nitro-utils merged so we can get the STAR randomness server up and running in prod. Thanks in advance

[kdenhartog]

I'm confused as to what parts here are relevant specifically to the nitro-shim utilities that we need done ASAP to get the star randomness server unblocked versus what's specific to the payments services that can be reviewed separately.

What's the motivation for merging all of the PRs together into one large change?

[husobee]

I'm confused as to what parts here are relevant specifically to the nitro-shim utilities that we need done ASAP to get the star randomness server unblocked versus what's specific to the payments services that can be reviewed separately.

This directory is specifically what should be focused on: https://github.com/brave-intl/bat-go/tree/nitro-payments-dev/nitro-shim and https://github.com/brave-intl/bat-go/tree/nitro-payments-dev/services/nitro for how we are running services in the enclave.

The rest of this PR is for the payments service which runs within the enclave.

What's the motivation for merging all of the PRs together into one large change?

It was becoming a nightmare to keep each branch up to date and make any progress since each of these are tightly integrated.

[kdenhartog]

Looks like all the port suggestions I made were incorrect because I misunderstood that a different addressing scheme is in use with these sockets. I've resolved them. Looking at what's left the only thing blocking would be bumping versions and making sure the brave-experiment references point at all of the brave packages now and the nitro-shim work is G2G then.

[husobee]

Looks like all the port suggestions I made were incorrect because I misunderstood that a different addressing scheme is in use with these sockets. I've resolved them. Looking at what's left the only thing blocking would be bumping versions and making sure the brave-experiment references point at all of the brave packages now and the nitro-shim work is G2G then.

https://github.com/brave-intl/bat-go/pull/1803 has the suggested implementations from security review for nitro-shim/nitro-utils

[github-actions[bot]]

The following commits were not verified: ea5e8fe74b0291305ce89540a3bf4f5f76ed02a0 (unsigned) fbb4daf458993a574e6e557f8b15640dd7b1aed7 (unsigned) bf52fe15ca75a3e5589db6ea7c87fd5c58607662 (unsigned) b3628b958d0464c7f9d0e7937f6ea071448b86dd (unsigned) cae12c4d552c3b88f60c5fefc33da47d3c4c8897 (unsigned) 1ace4ea69fb8cf71b055027a6fc9bd7082e0fda9 (unsigned) 585bf70f0f5958f6e56258283b7762dfcab83626 (unsigned) 723ef5f950c4f709d8149e2f492ece5f6c569ad9 (unsigned) ddd8c42c9c53fc25e6af28ce37641287984e096a (unsigned) 5dd0cf61265b6123133738a668bcb7fba9f74051 (unsigned) 2087bd7b129ecfdd023a7198bd8e9552a5daed41 (unsigned) de63a45e893b017a13f6eaa85c3d9ac5926e94ee (unsigned) 7aa52f733881f3ff343f9420fd1ea413b479e478 (unsigned) 370ec1c1259c5668a5218d517783523cdf765c89 (unsigned) 021955a137d4d0eb276d1236426fed4c5b27cd65 (unsigned) 5da3301a3e817a95d35eede0dd802ef05eae7c94 (unsigned) ba3b3f34d23cb2a8972a1fef05ecd994050c00c9 (unsigned) 92d61bb7c8322b9cdae8693abbcad237219f9d04 (unsigned) 87583304d21dcdeb2e8e3c73f206a1ab47ea1139 (unsigned) 00c3edd635ffe6bb41341cb2daf42ab66d5fb432 (unsigned) e56f609591da22b23fb069cb81f8da2342b0f246 (unsigned) 82434d05009376746ae54e62b4f8217f5de79d96 (unsigned) 8be574a2e83e8807435c1dddb6e118be4ab4872f (unsigned) 06559fa535e4bde7783ab9eecb04950863a7c200 (unsigned) 5210ecd4dd9b5a4c7523797f4f22a276d7fc15a8 (unsigned) 2189f4bfe089997284d3b787dc062760fd095212 (unsigned) eeab2c68abaada14098d26a01e166b45b39308e5 (unsigned)

[kdenhartog]

Closing since this PR isn't of much use to us at this point.

From the sounds of it we're planning to either split this code into a separate repository or if the intent is to keep it in here we'll re-open a new PR to merge this code in. At this point though it's clear it won't be done with this PR and next steps for us is to get back to using the normal PR process to merge onto this feature branch like we've been doing more recently.