Christian Wahle

Results 38 comments of Christian Wahle

I agree, I think it would be really nice to get things going, since there'll be some time needed to do some proper testing files in a staging env, especially...

@jankapunkt sounds fun ;) I personally always considered meteor-files rather complicated, maybe since I didn't really get it as a beginner... this could be a good opportunity to better understand...

> @dr-dimitru @jankapunkt @bratelefant is there a PR in the works for this? We're currently migrating to Meteor 3, and file uploads and downloads are core to the product. Sorry,...

I'm working on a fork, added async functions to `core.js` and `cursor.js`, currently working on `server.js`. I'd also like to add `protectedAsync` to the config, since often you do async...

Hi guys, please comment on this first attempt. In order to better understand what's going on I decided to add some tests for the server part, FilesCollection, core and cursor....

Gave it a pause to get some feedback first and pursued other tasks. Getting back to this soon.

> I'm glad this wasn't a hit-and-run type of PR. You took the time, added tests and improved the overall stability of the package. IMO, what remains is updating the...

> @bratelefant I'm going to clone it if you're not going to release. But it's ok to release unfinished work in incremental bits so it can be tested out like...

> @bratelefant please see my review and questions Will do that tomorrow ;)

> > @bratelefant please see my review, ~I assume you've satisfied your linter and now my is freaking out~ (solved with NPM update). Also please advise why we need `package.json`...