loyalty-card-locker icon indicating copy to clipboard operation
loyalty-card-locker copied to clipboard

Allow custom export folder

Open beng7 opened this issue 6 years ago • 5 comments

Hi Please allow user to be able to set custom Export folder as opposed to default /storage /emulated/0 --> e.g. to export to the nexcloud directory so cards are automatically backed up in nextcloud Thanks a lot

beng7 avatar Dec 24 '17 17:12 beng7

I think it is a good idea. I may not get to it right away, though. In the meantime, an alternative I can suggest is to share the backup data to another app and let it save it to the proper location. For example, Phone Saver (Google Play, F-Droid) will do just this. I have tested this app before and assisted with enhancements so it will work with my apps better.

brarcher avatar Dec 27 '17 02:12 brarcher

Hi Branden, Thanks for your reply. Will try as you advised + still look to a future update with the option. Let me thank you again for your excellent app + wish you a Happy New Year! Cheers ben

----- Original Message -----

From: "Branden Archer" [email protected] To: "brarcher/loyalty-card-locker" [email protected] Cc: "beng7" [email protected], "Author" [email protected] Sent: Wednesday, 27 December, 2017 3:36:40 AM Subject: Re: [brarcher/loyalty-card-locker] Allow custom export folder (#168)

I think it is a good idea. I may not get to it right away, though. In the meantime, an alternative I can suggest is to share the backup data to another app and let it save it to the proper location. For example, Phone Saver ( Google Play , F-Droid ) will do just this. I have tested this app before and assisted with enhancements so it will work with my apps better. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

beng7 avatar Dec 28 '17 10:12 beng7

+1

I might could contribute this one. Can you give an implementation pointers?

smoyte avatar Mar 10 '18 13:03 smoyte

@hooverlunch Recently I embedded a file picker into another of my apps. I think that it could be used here to specify the output folder. Take a look here for an example on adding the file picker, and documentation here.

My opinion is that from the ImportExportActivity if the user clicks on the Export button it should launch a file browser which asks to pick a directory. When the directory is selected the selected location is used to export the data. The filename itself can probably remain as LoyaltyCardKeychain.csv unless you feel strongly otherwise.

Note that there are unit tests which cover the import/export functionality and they would need to be updated as well.

brarcher avatar Mar 10 '18 18:03 brarcher

Yepp, duplicate, sorry for that. But yeah, custom folder appreciated - i might give phone saver a try too.

natrius avatar Apr 27 '18 13:04 natrius