Upload icon indicating copy to clipboard operation
Upload copied to clipboard

Implemented FlySystem for FileSystem abstraction

Open dubcanada opened this issue 10 years ago • 16 comments

Solves #41

I wasn't exactly sure if this is the best method or not, but it works. Basically I took out the FileStorage interface and replaced it with FlySystem.

dubcanada avatar Jul 25 '14 19:07 dubcanada

Thanks for this, shall take a look at it today.

scottrobertson avatar Jul 27 '14 08:07 scottrobertson

Sorry, been very busy. @codeguy can you take a look at this too?

scottrobertson avatar Aug 08 '14 12:08 scottrobertson

I am happy with this as a first step i think.

scottrobertson avatar Aug 08 '14 12:08 scottrobertson

Thoughts?

dubcanada avatar Sep 02 '14 23:09 dubcanada

I like. @scottrobertson what else do you have in mind?

codeguy avatar Sep 03 '14 01:09 codeguy

We should pick this up again, sorry i did not respond. Is this still ok to merge?

scottrobertson avatar Oct 11 '14 11:10 scottrobertson

Coming to this late but one thing to watch out for here is that FlySystem requires PHP 5.4+, while this library is currently baselined at 5.3.

bradleyboy avatar Oct 15 '14 21:10 bradleyboy

@bradleyboy Good point. I'm fine bumping the requirements. I'll do that shortly.

codeguy avatar Oct 15 '14 21:10 codeguy

@codeguy any update on this?

doorhinge avatar Nov 11 '14 21:11 doorhinge

@codeguy Not to be annoying, but I'm really interested in using this with Flysystem, so I'm just wondering if you plan on merging this? Thanks :smile:

doorhinge avatar Nov 19 '14 15:11 doorhinge

Any update on this PR?

mikealmond avatar Jan 07 '15 03:01 mikealmond

:+1: any ETA when this could possibly be implemented?

tamtamchik avatar May 21 '15 09:05 tamtamchik

Bump.

jeremykendall avatar Dec 08 '15 04:12 jeremykendall

Any update on this?

kaperys avatar Jan 15 '16 15:01 kaperys

Hellooooooo.... Is this repo still active?

napolux avatar Mar 30 '16 19:03 napolux

Will this be merged

solleer avatar Jul 01 '16 02:07 solleer