Brandon Kalinowski

Results 165 comments of Brandon Kalinowski

The issue occurs due to the visibility CSS prop. It looks like the hook is firing before the animated.div has a chance to update the style prop. https://gist.github.com/brandonkal/088da2bf362cf23df58cb9e1f9c263ab#file-drawer-tsx-L114-L117 Perhaps adding...

Thanks. Changing to use opacity over visibility worked to make the initial focus work. I am building reusable UI components. The behavior I want here is that when a Drawer...

FWIW, I prefer your `useFocusTrap` over `focus-trap` because it is half the bundle size. If you do want to go the `focus-trap` route, here is an [implementation](https://github.com/bmcmahen/sancho/blob/2cc7b94852b030bb7ff97eecbad6c65147dd681b/src/Hooks/focus.ts)

I am hoping someone is willing and able to test this out and release it in or let me know what needs to change. I am glad the CI tests...

Installing the nightly version fixed the issue. Everything looks good so far but I will report back after some more thorough testing.

Tested thoroughly and everything looks good to go!

Thank you for the reminder @schlessera. I forgot about this. I am not very familiar with Behat and my WordPress projects are currently on hold so I expect it will...

@jroebu14 If you are unaware, you no longer need to use `stylelint-processor-styled-components`. Stylelint now supports css-in-js syntax by default. **Some thoughts:** It would be nice to have regex but in...

That looks quite verbose. Styled Components already handles falsish values so I would write the above like this: ```js const example = css` height: ${({ height }) => height}; width:...