Brandon Henry
Brandon Henry
sooo looks like i only broke _some_ of the types.. 🙃
@iwiznia @jayeshmangwani alrighty, this is ready for review again. I altered phraseParameters so that it is no longer a rest parameter (thus resulting in `never[]`) and instead force use of...
this is awaiting review over at `expensify-common`. [PR](https://github.com/Expensify/expensify-common/pull/675)
@shubham1206agra example added where the fix is meant to be applied. Used 300 as the limit
@shubham1206agra any updates on this one 😄
@shubham1206agra just merged it in
@shubham1206agra let me know if you find anything on this, hopefully we can get this merged before Tuesday 🤞🏿
@shubham1206agra alrighty, did you have any examples of input that you saw weird output? I tested thoroughly and wasn't able to get anything weird, so just curious
@shubham1206agra do you actually notice any markdown breaking though? I did some digging here and I noticed that i had implemented this not how we want this to be. I...
@shubham1206agra i added comments to the function so you can better follow my logic and we can work together to resolve this one 👍🏿