flagship icon indicating copy to clipboard operation
flagship copied to clipboard

[Bug Report] iOS Deployment Target Desync

Open crherman7 opened this issue 1 year ago • 0 comments

Expected Behavior

The iOS deployment target specified in the podfile should match the iOS deployment target in the pbxproject.

Actual Behavior

By default the versions do match, but if you add the deploymentTarget to the environment file as something different than 12.4 the values will desync - this could create compile side-effects.

Issue areas

https://github.com/brandingbrand/flagship/blob/50647c419567bf0f50f726a2aea6cf52c64b38e0/packages/core/assets/template/ios/Podfile#L4

https://github.com/brandingbrand/flagship/blob/50647c419567bf0f50f726a2aea6cf52c64b38e0/packages/core/assets/template/ios/%7B%25%3D%20ios.name%20%25%7D.xcodeproj/project.pbxproj#L448 + https://github.com/brandingbrand/flagship/blob/50647c419567bf0f50f726a2aea6cf52c64b38e0/packages/core/assets/template/ios/%7B%25%3D%20ios.name%20%25%7D.xcodeproj/project.pbxproj#L513

Specifications

  • Version: @brandingbrand/code-core: 12.0.1
  • Platform: react-native: 0.71.+

Solution / Workaround

Add ejs template to this line: https://github.com/brandingbrand/flagship/blob/50647c419567bf0f50f726a2aea6cf52c64b38e0/packages/core/assets/template/ios/Podfile#L4.

crherman7 avatar Sep 12 '23 18:09 crherman7