react-native-maps-directions icon indicating copy to clipboard operation
react-native-maps-directions copied to clipboard

Automatic line colouring & steps

Open garydevenay opened this issue 6 years ago • 6 comments

When using a transit polyline, I added a prop to allow the line to be split and automatically coloured by the transit line type provided by Google.

I also added the journey steps to the onReady return object to facilitate the breakdown of a journey into multiple steps over many transit types.

garydevenay avatar May 20 '19 15:05 garydevenay

Thanks for this PR. It's a nice addition.

A few questions though:

  • Why did you remove region and optimizeWaypoints? This is a breaking change + has nothing to do with this PR.
  • Why did you change the mode from uppercase to lowercase? The casing is handled by the component itself. It is a breaking change (as the .ts definitions are also lagging now) + has nothing to do with this PR.

Please keep the contents of your PR limited to only the changes that it says it provides.

bramus avatar May 21 '19 12:05 bramus

@bramus Looks like I had some rouge VSCode extension removing unused props! Resolved both issues.

garydevenay avatar May 22 '19 09:05 garydevenay

@garydevenay Thanks for the extra pushed commits. It still looks a bit borked though, when you check the "files changed" tab.

Please go over your changes again. Don't be afraid to squash a few commits too, to keep the history clean.

Thanks.

bramus avatar May 22 '19 14:05 bramus

Any updates on this?

hawkeng avatar Jul 26 '19 21:07 hawkeng

this is such a useful feature. any update?

thorizer avatar Dec 07 '21 03:12 thorizer

this is such a useful feature. any update?

bump, any updates this would be awesome

adhendo avatar Apr 19 '22 07:04 adhendo