Bram Whillock comments

Results 89 comments of


                                            Bram Whillock

Provide nice way to insert data during config

This actually represents a chicken & egg problem for the service. The upgrade callback gets called when you try and use the database for the first time. So it's a...

Provide nice way to insert data during config

I suspect you would have to put the actual firing of the event itself in some kind of $timeout to actually allow the callstack to return. Seems simple enough but...

Provide nice way to insert data during config

Sure. Write the PR and it'll happen.

Wrong usage of @defer.reject()

What form of rejection would be preferred?

Wrong usage of @defer.reject()

Yes for sure. On Jul 11, 2016 3:13 AM, "Dmitriy Semyushkin" [email protected] wrote: > @bramski https://github.com/bramski will it be useful if I write PR > with this change? > >...

Wrong usage of @defer.reject()

Merged.

Is the DbQ object really necessary? Why not just use $q

Artifact from the original developer. It's probably unnecessary for deletion. Was necessary for some of the other functions. Please do submit a PR. Please make sure you modify the coffee...

Is the DbQ object really necessary? Why not just use $q

Please also write a test to ensure that deleteDatabase in the end does do as expected.

IE11 DataError on eachBy with no options

:+1:

IE11 DataError on eachBy with no options

I'll add a milestone to the project for IE11 support. There's another issue in that realm.