bramreinders97
bramreinders97
I don't think accepting regressors makes sense. The intuition behind RejectOptionClassifier is that we focus on the decisions that are made close to the decision boundary (i.e. with low confidence)....
From a practical perspective, I have no objections, as it is indeed a more general formulation. The only "worry" I have, is that this does not really capture the original...
Am I correct in my interpretation that we will now have two different classes (RejectOptionClassifier and Thresholder) with the same API, but with the difference that RejectOptionClassifier accepts binary classifiers...
>Am I correct in my interpretation that we will now have two different classes (RejectOptionClassifier and Thresholder) with the same API, but with the difference that RejectOptionClassifier accepts binary classifiers...
For `Thresholder` I would suggest the following logic for the class. Please let me know if this makes sense :) ```python def __init__(self, estimator, threshold_dict, prefit=False, predict_method='deprecated'): self.estimator = estimator...
```python check_is_fitted(self) base_predictions = np.array( _get_soft_predictions(self.estimator_, X, self._predict_method) ) _, base_predictions_vector, sensitive_feature_vector, _ = _validate_and_reformat_input( X, y=base_predictions, sensitive_features=sensitive_features, expect_y=True, enforce_binary_labels=False) positive_probs = 0.0*base_predictions_vector for a, interpolation in self.interpolation_dict.items(): interpolated_predictions =...
Hi, I'd be interested in picking this up. I will start at fairlearn.reductions, considering that @matthew-so is doing metrics right now.
Note that in _thresholder.py, I changed from relative to absolute imports. The reason for this is that I had many problems with the relative imports, and this fixed it for...
I'm wondering if I should include more tests? I feel like the main thing to test is if the output is as expected, which is the case.
There is a strange problem when testing `Thresholder` with a simple Pipeline (see code below/in one of the last commits). When testing in my local IDE (visual studio code using...