js-sequence-diagrams
js-sequence-diagrams copied to clipboard
Changes towards modularity
- changes in favor of explicit dependencies, i.e. require raphael and lodash
- support of webpack work flow
- include fixes of issues for latest lodash 4.0
- build using webpack instead of preprocessor
@bramp this PR is ready to merge, please consider to merge it and publish the package on npm.
I would like to see this as well. Both removing the dependency and adding npm.
I agree. Very nice, modern setup.
Small addition, in devserver.js
the static middleware must be placed after the webpack-middleware.
Otherwise you'll break up dev-mode, if there's a build\sequence-diagram.js
on the disk.
So put
app.use(express.static(process.cwd()));
after:
app.use(require('webpack-dev-middleware')(compiler, {
noInfo: true,
publicPath: config.output.publicPath,
}));
app.use(require('webpack-hot-middleware')(compiler));
@wollnyst thanks for tip about dev-mode, fixed!
include fixes of issues for latest lodash 4.0
Would be great if you included this PR agnostic of the other changes, ref https://github.com/bramp/js-sequence-diagrams/issues/158
has this effort been abandoned?