js-sequence-diagrams icon indicating copy to clipboard operation
js-sequence-diagrams copied to clipboard

Changes towards modularity

Open sergeyt opened this issue 9 years ago • 6 comments

  • changes in favor of explicit dependencies, i.e. require raphael and lodash
  • support of webpack work flow
  • include fixes of issues for latest lodash 4.0
  • build using webpack instead of preprocessor

This change is Reviewable

sergeyt avatar Jan 13 '16 16:01 sergeyt

@bramp this PR is ready to merge, please consider to merge it and publish the package on npm.

sergeyt avatar Jan 14 '16 09:01 sergeyt

I would like to see this as well. Both removing the dependency and adding npm.

ntotten avatar Jan 21 '16 03:01 ntotten

I agree. Very nice, modern setup.

Small addition, in devserver.js the static middleware must be placed after the webpack-middleware. Otherwise you'll break up dev-mode, if there's a build\sequence-diagram.js on the disk.

So put

app.use(express.static(process.cwd()));

after:

app.use(require('webpack-dev-middleware')(compiler, {
    noInfo: true,
    publicPath: config.output.publicPath,
}));

app.use(require('webpack-hot-middleware')(compiler));

wollnyst avatar Jan 23 '16 12:01 wollnyst

@wollnyst thanks for tip about dev-mode, fixed!

sergeyt avatar Jan 24 '16 05:01 sergeyt

include fixes of issues for latest lodash 4.0

Would be great if you included this PR agnostic of the other changes, ref https://github.com/bramp/js-sequence-diagrams/issues/158

dcousens avatar Jul 24 '16 03:07 dcousens

has this effort been abandoned?

rparree avatar Mar 30 '18 09:03 rparree