js-sequence-diagrams icon indicating copy to clipboard operation
js-sequence-diagrams copied to clipboard

Added version to package.json and circled actors

Open imrefazekas opened this issue 9 years ago • 8 comments

imrefazekas avatar Jan 13 '16 00:01 imrefazekas

I also extended the grammar to able to express special actors drawn with ellipse.

imrefazekas avatar Jan 28 '16 13:01 imrefazekas

Would you add some tests for the new oval syntax.

Also if I read this correctly, if I prefix the actor name with o- then it becomes a oval. I wonder if that is the most obvious/sensible way to do this.

bramp avatar Jan 28 '16 15:01 bramp

Also if I read this correctly, if I prefix the actor name with o- then it becomes a oval ---- yes. I use it to make differentiate actors dealing with internal communication or external as well. Whether they possess interface open to the public... The signal came from the world of UML actually or at least has a good association with the connected circle of UML. :) I do the tests asap....

imrefazekas avatar Jan 28 '16 17:01 imrefazekas

Test added.

imrefazekas avatar Jan 28 '16 18:01 imrefazekas

You branch has conflicts. Can you rebase from master, so I can merge.

I will look over the code more, but I want to think more about this if this is the right syntax to be using.

bramp avatar Jan 28 '16 18:01 bramp

Done, hopefully the correct way...

imrefazekas avatar Jan 29 '16 16:01 imrefazekas

I was wondering if we could introduce some syntax to add stereotypes in some way ...

imrefazekas avatar Jan 29 '16 16:01 imrefazekas

Changed the prefix to () to mark it as circle. And I also introduced <> to mark it as rhombus. Better fitting syntax I think...

imrefazekas avatar Jan 30 '16 22:01 imrefazekas