ffmpeg-cli-wrapper icon indicating copy to clipboard operation
ffmpeg-cli-wrapper copied to clipboard

Propagate FFmpegError through FFmpegException on FFprobe failures

Open barnettj opened this issue 4 years ago • 1 comments
trafficstars

Similar idea to https://github.com/bramp/ffmpeg-cli-wrapper/pull/214 but for ffprobe. Ffprobe actually already deserialises the errors into FFmpegError (Error codes too!) in the FFmpegProbeResult. The result is never returned though as we discard everything and throw IOException.

This change throws FFmpegException which contains the FFmpegError and will allow consumers to easily handle things like 401/404 scenarios on remote files.

barnettj avatar Dec 10 '20 11:12 barnettj

Coverage Status

Coverage increased (+0.1%) to 84.711% when pulling 76afbfd7327f89fa5d6bf9a3a1d452a8f736b3a5 on barnettj:master into 19923fb8e88c8704c4e31dc9fb2931a770a49fed on bramp:master.

coveralls avatar Dec 10 '20 12:12 coveralls