ffmpeg-cli-wrapper icon indicating copy to clipboard operation
ffmpeg-cli-wrapper copied to clipboard

Issue 191 out time us

Open yermak opened this issue 5 years ago • 1 comments
trafficstars

Fix of issue #191. I saw other pull request and considerations about fixing out_time_ms, according to current code base we could just ignore it, as it just duplicates out_time_us. av_bprintf(&buf_script, "out_time_us=%"PRId64"\n", pts); av_bprintf(&buf_script, "out_time_ms=%"PRId64"\n", pts); av_bprintf(&buf_script, "out_time=%s%02d:%02d:%02d.%06d\n", hours_sign, hours, mins, secs, us); This is fixed in issue https://trac.ffmpeg.org/ticket/7345

So, I believe we could just ignore out_time_ms. However, the bigger questions - do we need to parse string to get actual time or we could just rely on out_time_us?

yermak avatar Nov 15 '20 20:11 yermak

Coverage Status

Coverage decreased (-0.04%) to 84.57% when pulling a5a677aae4140d108705a0a7e2b45efa6388e925 on yermak:issue/191_out_time_us into 19923fb8e88c8704c4e31dc9fb2931a770a49fed on bramp:master.

coveralls avatar Nov 15 '20 20:11 coveralls

Thanks. Sorry its taken me ~3 years to reply. This was fixed by someone else in https://github.com/bramp/ffmpeg-cli-wrapper/pull/289

I will try to release shortly.

bramp avatar Oct 26 '23 05:10 bramp