ffmpeg-cli-wrapper icon indicating copy to clipboard operation
ffmpeg-cli-wrapper copied to clipboard

audioFilter and videoFilter should be swapped

Open detistov opened this issue 6 years ago • 3 comments

Describe the bug A clear and concise description of what the bug is.

The option for videofilter in ffmpeg is -vf and for and for audio is -af. The values in the FFmpegBuilder should be swapped.

To Reproduce

// Example code

Expected behavior A clear and concise description of what you expected to happen.

Version (if applicable):

  • OS: [e.g. Linux]
  • Java Version [e.g. 8]

Additional context Add any other context about the problem here.

detistov avatar Feb 11 '19 15:02 detistov

Just encountered this problem myself. Sounds like an easy fix since only the names need to be swapped. atm "setVideoFilter" sets audio filters and vice versa.

slurba avatar Feb 27 '19 14:02 slurba

In FFmpegBuilder, should be:

if (!Strings.isNullOrEmpty(videoFilter)) { args.add("-vf", videoFilter); }

if (!Strings.isNullOrEmpty(audioFilter)) {
  args.add("-af", audioFilter);
}

aeromac avatar Feb 19 '20 03:02 aeromac

What about is this issue? I could create an PR if wanted, but this issue seems rather trivial.

daniel-naegele avatar Apr 08 '22 23:04 daniel-naegele

@bramp This has been fixed in commit 94a8658

Euklios avatar Mar 09 '24 18:03 Euklios