ffmpeg-cli-wrapper
ffmpeg-cli-wrapper copied to clipboard
audioFilter and videoFilter should be swapped
Describe the bug A clear and concise description of what the bug is.
The option for videofilter in ffmpeg is -vf and for and for audio is -af. The values in the FFmpegBuilder should be swapped.
To Reproduce
// Example code
Expected behavior A clear and concise description of what you expected to happen.
Version (if applicable):
- OS: [e.g. Linux]
- Java Version [e.g. 8]
Additional context Add any other context about the problem here.
Just encountered this problem myself. Sounds like an easy fix since only the names need to be swapped. atm "setVideoFilter" sets audio filters and vice versa.
In FFmpegBuilder, should be:
if (!Strings.isNullOrEmpty(videoFilter)) { args.add("-vf", videoFilter); }
if (!Strings.isNullOrEmpty(audioFilter)) {
args.add("-af", audioFilter);
}
What about is this issue? I could create an PR if wanted, but this issue seems rather trivial.
@bramp This has been fixed in commit 94a8658