ffmpeg-cli-wrapper icon indicating copy to clipboard operation
ffmpeg-cli-wrapper copied to clipboard

Published 20 hours ago • verified publisher icon bramp

Added support for input devices/streams and tests

Open Omar-Riaz opened this issue 6 years ago • 4 comments

I created a subclass called FFMpegInputBuilder which extends the AbstractFFmpegStreamBuilder. Seeing that the AbstractFFmpegInputBuilder was designed for outputs, I re-implemented the filename property and build method to retain all previous functionality.

I also added tests to see that the inputs are built properly, modelled after #156 . I added a convenience method to parse commands separated by spaces for assertion purposes.

From the FFmpegBuilder, you simply call addInputStream(String inputStream) to build the input.

Omar-Riaz avatar Aug 27 '18 15:08 Omar-Riaz

Updated test to support device_number. Is it ok to include the parameter if there are no duplicates and it is set to zero?

Omar-Riaz avatar Aug 27 '18 16:08 Omar-Riaz

Coverage Status

Coverage increased (+2.3%) to 84.106% when pulling 3da1165fef8c31b69b36259c8a8783dbec8cc130 on Omar-Riaz:master into 3819b155edf9132acc75bb6af66dcef1b98c64b2 on bramp:master.

coveralls avatar Aug 27 '18 16:08 coveralls

Thanks for the PR. I'm on vacation for the next week, so I won't look at this until later next week. Feel free to ping me if I don't respond next week.

bramp avatar Aug 27 '18 18:08 bramp

Hi @bramp , did you get a chance to review?

Omar-Riaz avatar Sep 09 '18 16:09 Omar-Riaz