Andrew Brampton
Andrew Brampton
Awesome, thanks for the work! I reviewed the code, and it looks good, but it is sad to see how much has to change to make this work. I had...
I've just updated the [README](https://github.com/bramp/ffmpeg-cli-wrapper#get-progress-while-encoding) to show an example of the ProgressListener with percentage complete. The percentage complete is tricky (due to having multiple streams, etc), so I've made it...
doh, I also renamed that, it was called "progress" (which I thought was a bad name, progress.progress).
"Invalid bitrate 'N/A'", gah I have a [TODO](https://github.com/bramp/ffmpeg-cli-wrapper/blob/master/src/main/java/net/bramp/ffmpeg/progress/Progress.java#L136) to handle that, but did not encounter it in my test files. I will fix that, and I'm going to make a...
I think this issue is resolve. Feel free to reopen if you need more help. Thanks.
Sorry for the long delay! This looks good accepted!
Something looks very wrong on this PR :/ It seems to include ALL changes over the last 7 years. I'm going to close it, but please reopen a new one...
Your diff seemed to change all the whitespace in `pom.xml` which made it hard to review. However, we have since updated the various plugins/deps, so this shouldn't be a problem...
I think it looks good. I've added feedback on the pr. Thanks
This was merged over in https://github.com/bramp/ffmpeg-cli-wrapper/pull/304 ! thanks