antlr4-grammars icon indicating copy to clipboard operation
antlr4-grammars copied to clipboard

Rename "range" to "range_" to allow plsql to be generated

Open tgulacsi opened this issue 8 years ago • 1 comments

diff --git a/Makefile b/Makefile
index c736ddb..bce3572 100644
--- a/Makefile
+++ b/Makefile
@@ -64,7 +64,7 @@ grammars-v4:
 # and creates a slightly different set of named files. This makes it
 # difficult to have one file. This is the best hack that keeps Make
 # working correctly.
-BUILD=sh -c '\
+BUILD=bash -c '\
        basedir=$$PWD; \
        errors=$$0/$$(basename $$1).log; \
        mkdir -p $$0; \
@@ -1029,7 +1029,9 @@ plsql plsql/plsql_test.go: plsql/plsqlparser_base_listener.go plsql/plsqlparser_
 plsql/doc.go: plsql/plsql_test.go

 %/plsqlparser_base_listener.go %/plsqlparser_listener.go %/plsql_parser.go: grammars-v4/plsql/PlSqlParser.g4 plsql/plsql_lexer.go
-       ${BUILD} plsql grammars-v4/plsql/PlSqlParser.g4 plsql/plsqlparser_base_listener.go plsql/plsqlparser_listener.go plsql/plsql_parser.go
+       mkdir -p grammars-v4/plsql/mod
+       sed -e 's/range/range_/g' grammars-v4/plsql/PlSqlParser.g4 >grammars-v4/plsql/mod/PlSqlParser.g4
+       ${BUILD} plsql grammars-v4/plsql/mod/PlSqlParser.g4 plsql/plsqlparser_base_listener.go plsql/plsqlparser_listener.go plsql/plsql_parser.go

 %/plsql_lexer.go: grammars-v4/plsql/PlSqlLexer.g4
        ${BUILD} plsql grammars-v4/plsql/PlSqlLexer.g4 plsql/plsql_lexer.go

tgulacsi avatar Dec 12 '17 13:12 tgulacsi

Very awesome, but the Makefile is generated by makemake.go. So your changes would be undone.

Instead, what I would accept is some change to the makefile generation to accomplish this in an generic way. For example, having a directory of patch files, that would be applied before trying to compile.

bramp avatar Dec 13 '17 22:12 bramp