Duncan Cameron

## Description The import of a file from the command line currently fails with `Error: Invalid security token, please reload the page and try again` I suspect this is due...

Shortening text that needs to be multibyte aware

1

## Description `shortenTextDisplay()` currently returns a `span` element which can be used when displaying URLs or email addresses. This change splits the part of shortening text that needs to be...

The definition of this table has a unique index for the email column. But the way that the table is used seems to imply that there can be multiple rows...

Problems with showing private lists on the preferences page

1

A problem raised in the user forum https://discuss.phplist.org/t/showing-private-lists-seems-to-be-broken/6031 seems to show this earlier commit doesn't work as intended https://github.com/phpList/phplist3/pull/559 In "normal" processing a subscribe page can include only public lists....

The admin/locale directory does not match GitHub

2

In the released phplist the directory admin/locale doesn't match that in GitHub, e.g. admin/locale/en/pagetitles.php which I was looking at to see why a page title was not being found. Is...

Dependency on php version 5.4

2

An earlier pull request used the short array syntax assuming that php version 5.4 or later is being used. https://github.com/phpList/phplist3/pull/543/files#diff-c24d5bdfa2b25ebe4461a8063f6b83a8R910 But it is still the case that phplist allows php...

Ambiguous date format when checking for an update

1

This code in file admin/updatelib.php added to check for an update looks to be error prone ``` function lastTimeCheck() { $doCheck = false; $currentTime = date('m/d/Y h:i:s', time()); $lastCheckTime =...

Rendering of pages on resources.phplist.com

2

I have noticed a change in how some pages are formatted. A single underscore seems to be treated as starting italic, in addition to the usual `//`. This messes up...

Using php 8.1 I get deprecations for use of null parameter to str_replace() ``` PHP Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in /home/duncan/Development/GitHub/phplist3/public_html/lists/admin/defaultconfig.php...

Avoid php 8 deprecation for a null attribute value

1

## Description Using php 8 a deprecation warning is issued when using stripslashes() on a null attribute value `[Sun Sep 11 21:30:33.465091 2022] [php:notice] [pid 3075] [client 127.0.0.1:44934] PHP Deprecated:...