swipe-card icon indicating copy to clipboard operation
swipe-card copied to clipboard

Update Swiper

Open breakthestatic opened this issue 1 year ago • 3 comments

Updated the Swiper library to a much more recent version.

I was specifically having an issue with shadow DOM targeting (for the noSwipingSelector) that was fixed somewhere in v8 (used deprecated/non-standard event.path instead of event.composedPath()).

There's definitely potential that this introduces breaking changes for existing swipe-card users, as the underlying Swiper API may have changed; I didn't go through all the changes from v6 to v10...) However, it would make this component more in sync with the linked Swiper documentation, etc.

In addition to bumping Swiper to the most current version, I also bumped two other dependencies to resolve some security issues.

If you don't want to move to a new version, I totally understand. I just figured I'd offer this, as I've been using it locally for a while.

breakthestatic avatar Sep 07 '23 21:09 breakthestatic

@breakthestatic Can you share a compiled JS file here?

ildar170975 avatar Sep 13 '23 00:09 ildar170975

Thank you, found JS file in dist

ildar170975 avatar Sep 13 '23 00:09 ildar170975

@bramkragten, just wanted to ping you, as someone in the forums was asking if this project was dead. Getting up-to-date with the underlying library could definitely help in that regard.

breakthestatic avatar Oct 23 '23 23:10 breakthestatic