braintree_ruby icon indicating copy to clipboard operation
braintree_ruby copied to clipboard

Version 4.27 includes breaking changes, does not follow semver

Open hollabaq86 opened this issue 8 months ago • 1 comments

Issue

4.27.0 includes the removal of code that could be a breaking change.

There's comments that were removed as part of these changes that say NEXT_MAJOR_VERSION, yet this was released as a minor version bump.

The CHANGELOG is too vague and does not include all the code that has been removed.

Why this matters

Developers depend on semantic versioning to trust the version they're downloading doesn't break their integration. Removing code without explicit details in the CHANGELOG makes it difficult for developers to understand what's changing.

Even if a product is deprecated, there is still a chance that a result object contains information that a developer may be using in a way you didn't anticipate.

Proposed fix

yank 4.27, and release these changes as 5.0

hollabaq86 avatar May 07 '25 15:05 hollabaq86

Hi @hollabaq86 thank you for bringing this to our attention. It was our impression that all of the features surrounding marketplace may have been too large to list in the changelog. Additionally, it was our understanding that this should not include any breaking changes as there shouldn't be any merchants making use of anything related to that particular feature.

I will raise this to the team and try to respond promptly.

klaguerrePay avatar May 07 '25 19:05 klaguerrePay