braintree_ruby icon indicating copy to clipboard operation
braintree_ruby copied to clipboard
verified publisher icon braintree

Apple Pay Card does not expose Cardholder Name

Open AxelTheGerman opened this issue 3 years ago • 2 comments

General information

  • SDK/Library version: any
  • Environment: any
  • Language, language version, and OS: Ruby, MacOS

Issue description

I'm looking at the docs here: https://developer.paypal.com/braintree/docs/reference/response/apple-pay-card#cardholder_name and the code here: https://github.com/braintree/braintree_ruby/blob/f18d293b91d4c44e801f213313d6f777fc08a99b/lib/braintree/apple_pay_card.rb#L14

I can see the @cardholder_name instance variable and (being Ruby) can even access it with

> apple_pay_card.instance_variable_get :@cardholder_name
=> "AmEx Apple Pay Cardholder"

I believe an attr_accessor is all that's missing.

On another note though, I see billing_address in the docs but not in the SDK anywhere

AxelTheGerman avatar May 25 '22 20:05 AxelTheGerman

👋 @AxelTheGerman thanks for reaching, we're going to reach out to the engineering team behind our Apple Pay integration to get this fixed up. I'll leave this open until that's resolved.

hollabaq86 avatar May 26 '22 14:05 hollabaq86

@hollabaq86 just to support things a bit more, I took the liberty to provide a PR. Hope that helps :)

AxelTheGerman avatar Jun 02 '22 22:06 AxelTheGerman

This was merged and released in the latest version of the SDK (4.9.0)

saralvasquez avatar Dec 20 '22 00:12 saralvasquez