braintree_ios icon indicating copy to clipboard operation
braintree_ios copied to clipboard

Use ASWebAuthenticationSession for PaymentFlowDriver

Open scannillo opened this issue 4 years ago • 3 comments

Thank you for your contribution to Braintree.

Before submitting this PR, note we cannot accept language translation PRs. We support the same languages that are supported by PayPal, and have a dedicated localization team to provide the translations. If there is an error in a specific translation, you may open an issue and we will escalate it to the localization team.

Summary of changes

Checklist

  • [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

scannillo avatar Sep 09 '21 20:09 scannillo

Posting for posterity: I created this branch https://github.com/braintree/braintree_ios/tree/asweb-take2 which takes a different approach to trying to unit test this flow. It removes the ASWeb wrapper class, and instead calls handleOpenURL directly from the unit test, instead of trying to mock the ASWeb part of the flow here. I think this is a more straightforward path for us to unit test this.

scannillo avatar Dec 20 '21 15:12 scannillo

@scannillo 😨 😭 😭

sshropshire avatar Jan 21 '22 21:01 sshropshire

@scannillo gotta 🪃 to close now lol

sshropshire avatar Jan 21 '22 21:01 sshropshire

Closing due to inactivity. See comment for details on picking up this work, if time permits.

scannillo avatar Aug 16 '22 20:08 scannillo