braintree_android
braintree_android copied to clipboard
Venmo Universal/App Links
Summary of changes
- Add
setFallbackToWeb()
toVenmoRequest
- If set to
true
customers will fallback to a web based Venmo flow if the Venmo app is not installed - This method uses App Links instead of Deep Links
- If set to
- Add
VenmoClient#parseBrowserSwitchResult(Context, Intent)
method - Add
VenmoClient#clearActiveBrowserSwitchRequests(Context)
method - Add
VenmoClient#onBrowserSwitchResult(BrowserSwitchResult, VenmoOnActivityResultCallback)
method - This feature has been added to the Demo app, select "Venmo Fallback to Web" in the Settings menu to test this flow
- Add unit tests
Checklist
- [x] Added a changelog entry
- [x] Relevant test coverage
Authors
@jaxdesmarais @sarahkoop @jwarmkessel @tdchow
Left a few nitpick comments around naming and testing but otherwise 🔥
Waiting to merge this, there are some issues with the Venmo app return currently on both the standard flow and this new flow. Waiting for those to get resolved to do a final round of testing before merging.
Update: this is due to backend issue with our sandbox account. Testing in prod works as expected. Waiting to merge based on decision for if this should be behind a feature flag or not.
We have completed our test cases for this flow based on current versions of the Venmo app. The Venmo team will be completing backwards compatibility testing off of this branch. Once their tests are complete as well we should be able to remove the "do not merge" tag.
Backwards compatibility testing is complete and the E2E testing team has verified these changes. 🥳