feat: implemented a param to specify any vaulted payment method type that they want to block.

[ale-grosselle]

Summary

~~Implemented vaultedPaypalAccountsDisabled argument.
If set to true, it force to disable paypal vault.~~

Implemented vaultedPaymentMethodTypesThatShouldBeHidden. It accepts an array of paymentMethodTypes (e.g CreditCard, PayPalAccount) and specify any vaulted payment method type that want to block. Important: ApplePayCard, VenmoAccount, AndroidPayCard are always blocked.

This is very useful when you have two different payment flows and on one it is not possible to enable paypal vaulting (due to legal restriction for example).

Checklist

• [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

[crookedneighbor]

I think this should be done more holistically and allow the merchant to specify any vaulted payment method type that they want to block.

Also, I think it should be a parameter under vaultManager, not a top level parameter.

[ale-grosselle]

@crookedneighbor good point, I'm going to implement your suggestions!

[ale-grosselle]

@crookedneighbor "I think it should be a parameter under vaultManager", could you explain to me where I would add the parameter?

I didn't find in this project :/

[crookedneighbor]

My mistake the vaultManager option is a boolean, not an object: https://github.com/braintree/braintree-web-drop-in/blob/bf05e9a9ad10a7b22ccc80fa2e86561d16d7ed72/src/index.js#L269

Making it a top level object with the payment methods to hide as the keys should be fine.

[ale-grosselle]

@crookedneighbor Implemented the param if you want to take a look!

[crookedneighbor]

Made a couple of adjustments, added a changelog entry and rebased. I force pushed the changes, so if you have this checked out locally, you'll need to fetch the changes and reset to the remote branch if you need to make any changes.

[ale-grosselle]

Hello @crookedneighbor, any news?

[shango420]

Perfecto buen trabajo

[ale-grosselle]

Any news, could we merge it please? 🙏 🙏

[shango420]

👍👍

[ale-grosselle]

Hello @crookedneighbor, any news?

[armandodlvr]

@ale-grosselle could you please rename vaultedPaymentMethodTypesThatShouldBeHidden to hiddenVaultedPaymentMethodTypes ? and resolve conflicts to merge your PR. Thanks

[ale-grosselle]

Hi @armandodlvr done!

[shango420]

Summary

~~Implemented vaultedPaypalAccountsDisabled argument.
If set to true, it force to disable paypal vault.~~

Implemented vaultedPaymentMethodTypesThatShouldBeHidden. It accepts an array of paymentMethodTypes (e.g CreditCard, PayPalAccount) and specify any vaulted payment method type that want to block. Important: ApplePayCard, VenmoAccount, AndroidPayCard are always blocked.

This is very useful when you have two different payment flows and on one it is not possible to enable paypal vaulting (due to legal restriction for example).

Checklist

• [x] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

[armandodlvr]

@ale-grosselle the changelog was removed. could you add it?... thanks

[ale-grosselle]

hiddenVaultedPaymentMethodTypes

Done!

@ale-grosselle the changelog was removed. could you add it?... thanks

[ale-grosselle]

@armandodlvr is it okay now?

[shango420]

vaultedPaymentMethodTypesThatShouldBeHidden

[ale-grosselle]

Hello @cgdibble @crookedneighbor, is possible to merge this PR?

Thanks

[cgdibble]

I'm going to have some teammates take a look as an extra set of eyes in the morning, but otherwise it looks good and we should be able to merge it tomorrow.