ultimate-addons-for-gutenberg icon indicating copy to clipboard operation
ultimate-addons-for-gutenberg copied to clipboard

Improvement - Add animation settings field in the Advanced Section for all blocks

Open mangeshsonule opened this issue 4 years ago • 3 comments

Description

https://trello.com/c/wJY5Amfa/82-animation-option

Screenshots

Types of changes

New feature (non-breaking change which adds functionality)

How has this been tested?

Drag and drop any block. you can show the new settings option under the Advanced Tab.

Checklist:

  • [x] My code is tested
  • [ ] My code follows accessibility standards
  • [ ] My code has proper inline documentation
  • [ ] I've included any necessary tests
  • [ ] I've included developer documentation
  • [x] I've added proper labels to this pull request

mangeshsonule avatar Dec 04 '20 07:12 mangeshsonule

  • Blank classes are added - https://share.getcloudapp.com/xQuYDXkl
  • Should this work for Parent Blocks to? Ex: Buttons? Instead of Child button block.
  • Not working for Post Grid.
  • When I deactivate some of the blocks from backend, the animation CSS does not work.

vrundakansara avatar Dec 07 '20 12:12 vrundakansara

Blank classes are added - https://share.getcloudapp.com/xQuYDXkl Should this work for Parent Blocks too? Ex: Buttons? Instead of Child button block. When I deactivate some of the blocks from the backend, the animation CSS does not work.

=> Fixed all the above issues.

Not working for Post Grid. => Post module register with PHP and React hooks worked on the saved function. That's why not working for the Grid module

mangeshsonule avatar Dec 15 '20 05:12 mangeshsonule

@mangeshsonule

  • Add Proper prefix for the PR Title. eg( fix, improvement, new )
  • In the description don't just copy & paste the title of the PR, either add a proper description or just simply add a Trello task link.
  • Also, Whenever you give a PR for review the assign the specific task to the reviewer and add the Needs code review label to it.

RajkiranBagal avatar Dec 15 '20 07:12 RajkiranBagal