ultimate-addons-for-gutenberg icon indicating copy to clipboard operation
ultimate-addons-for-gutenberg copied to clipboard

Fix: CSS not applying on responsive devices and multi-buttons settings not visible in editor issue.

Open AbhijitNage123 opened this issue 3 years ago • 4 comments

Description

= 1.25.4 =

  • Fix: CSS not applying on responsive devices.
  • Fix: Multi Buttons - Child setting are not visible in editor.

Changes Made

  • Add deviceType attribute in attribute.js
  • Update deviceType attribute withSelect
  • use addBlockEditorDynamicStyles componentDidUpdated
  • Updated css class in styling.js

Screenshots

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Test cases for Responsive CSS
    • Add color or any style to block and check it in tablet/mobile preview.
    • Add a responsive CSS like font size on tablet/mobile and check if it applies in the editor or not.
    • Check style tag is loaded in an iframe when the preview is tablet/mobile.
  • Test case for multi-buttons
    • Drag and drop multi-button in master
    • Click on the button child and check child setting is visible or not.
    • Switch to the above branch and it will get displayed.
  • Masonry changes
    • It is already tested and released no need to test.

Checklist:

  • [x] My code is tested
  • [ ] My code follows accessibility standards
  • [ ] My code has proper inline documentation
  • [x] I've included any necessary tests
  • [ ] I've included developer documentation
  • [x] I've added proper labels to this pull request

AbhijitNage123 avatar Feb 02 '22 13:02 AbhijitNage123

@AbhijitNage123 All the changes you have done in this PR should be represented in the title, description and each change should have their test cases in the Pr description. Currently the title, description and testcases are only for the one change.

RajkiranBagal avatar Feb 04 '22 13:02 RajkiranBagal

Updated the test case in the PR description.

AbhijitNage123 avatar Feb 04 '22 13:02 AbhijitNage123

Updated the test case in the PR description. Please update PR title and description accordingly

RajkiranBagal avatar Feb 04 '22 13:02 RajkiranBagal

working fine

akshaylakh avatar Feb 07 '22 07:02 akshaylakh