all-in-one-schemaorg-rich-snippets icon indicating copy to clipboard operation
all-in-one-schemaorg-rich-snippets copied to clipboard

Published 20 hours ago • verified publisher icon brainstormforce

Update index.php for text-domain issue

Open alexclassroom opened this issue 3 years ago • 2 comments

This plugin's slug is all-in-one-schemaorg-rich-snippets, but your Text Domain is rich-snippets. Change your Text Domain so it is equal to your slug and modify the text domain in all your source files. This change is needed because your "Requires at least" is below 4.6. See https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains

I think these changes can also trigger the plugin's GlotPress project to update strings to 339 items (current items are 254).

alexclassroom avatar May 18 '21 07:05 alexclassroom

@alexclassroom will this be a backward compatibility break for all existing sites that have custom translations using the old text-domain?

Nikschavan avatar Jul 27 '21 11:07 Nikschavan

If you changed text-domain, and complete existing languages' GlotPress projects, all laguage packs will be pushed to the sites installed this plugins and updated by system.

If you are affraid to lost the control of language pack, please consider apply to Cross-region PTE for your all plugins, then you can upload and approve all language pack you have.

This also mean you don't package and language pack files to plugin/theme ZIP file.

Is it a better idea?

alexclassroom avatar Jul 27 '21 17:07 alexclassroom