brainstorm3 icon indicating copy to clipboard operation
brainstorm3 copied to clipboard

Published 20 hours ago • verified publisher icon brainstorm-tools

Update bst_connectivity.m

Open danielemarinazzo opened this issue 2 years ago • 2 comments

Specified that wPLI is not the debiased one (see https://github.com/brainstorm-tools/brainstorm3/issues/571), and added the debiased version commented below. This until we figure out how to implement the debiased wPLI in time domain

danielemarinazzo avatar Sep 20 '22 09:09 danielemarinazzo

@Moo-Marc Can you please review this PR? Are there things to change in the documentation or the process GUI?

Thanks

ftadel avatar Sep 21 '22 13:09 ftadel

I'm working on a PR for proper file averaging that will incorporate these fixes and allow the debiased version. We can close this PR once I submit it.

Moo-Marc avatar Sep 21 '22 16:09 Moo-Marc

since this is taking long, wouldn't be good to merge this PR for the moment, which anyway clarifies things albeit some measures still need to be developed?

danielemarinazzo avatar Mar 02 '23 15:03 danielemarinazzo

Hi Daniele,

I expect to get back to this within a few weeks so I'd suggest to wait. I'd avoid merging a "fix" or new option that is itself known to be problematic (the trial averaging issue).

Moo-Marc avatar Mar 02 '23 17:03 Moo-Marc

Sure nevermind. Just to be clear, this PR is not a fix for the trial averaging, it's just the current version, but with the non debiased wPLI, and the debiased one commented.

danielemarinazzo avatar Mar 02 '23 19:03 danielemarinazzo

The proposed changes were included in PR #632, which was merged in https://github.com/brainstorm-tools/brainstorm3/commit/24e3d224b2f93614f960231a308fd67cb7c85714

rcassani avatar Aug 23 '23 18:08 rcassani