brainstorm3
brainstorm3 copied to clipboard
Optical Flow Update and Helmholtz Hodge Decomposition Enabling
Hello, Here are the changes I commited in my pull request:
Minor code updates and corrections on:
- panel_opticalflow
- bst_opticalflow_states
- bst_opticalflow
Enabling Helmholtz-Hodge Decomposition:
- panel_opticalflow (gui perspective)
- bst_opticalflow_hhd (new function, maths)
Thanks, Léo
Thank you Leo for your update. You are only modifying files related to the optical flow so this is a pretty safe merge. Were you planning on writing a documentation for your changes? This would greatly help us test this.
Some minor comments right off the bat:
- The GUI freezes and it takes a long time to compute after you click on a big source file and go to Plug-Ins -> [Experimental] Optical flow. Is it possible to add a progress bar to tell the user a computation is happening so they know their computer is not frozen? Refer to bst_progress.
- Some code is commented out without explanation
- There are some comments in French in the code ;)
Great work! Martin
@LeoNouvelle Is this PR still a work in progress?
Xiaobo is working on the scientific/methods developments. Will contribute to Brainstorm tools updates when ready.
Sylvain.