salto_simulator

salto_simulator copied to clipboard

The const declarations in "include/cpu.h" need to be extern

1

In order to be correct and to avoid multiple-definition errors from some linkers, declarations like `const char *task_name[task_COUNT];` actually need to be marked `extern` as well.

eschaton

Attempting to compile with gcc-10 (specifically gcc-10.2.0) results in an error during linking. Build log is [here](https://pastebin.com/hqyx4LiV). Note that downgrading to gcc-9 in the Makefile worked around this issue. On...

Shoegzer

Without this include, salto doesn't compile with clang on osx

mschuetz

In `md5_update` the `len` parameter is `unsigned` and in `fp_write_bytes` the `size` parameter is `int`. They should both be `size_t` to avoid 32/64-bit warnings on some platforms.

eschaton

The code in src/drive.c that calls `fread(3)` treats its return (a `size_t`) as if it were the return from `read(2)` (a `ssize_t`). For `fread(3)` the return value will never be...

eschaton

In src/md5.c, there’s a case where `memset` is called with `sizeof(ctx)` which is a pointer variable, and thus isn’t doing what’s expected.

eschaton