pgbouncer
pgbouncer copied to clipboard
Don't reveal the password on startup
When I get the logs of my container, I get something like:
create pgbouncer config in /etc/pgbouncer
#pgbouncer.ini
# Description
# Config file is in “ini” format. Section names are between “[” and “]”.
# Lines starting with “;” or “#” are taken as comments and ignored.
# The characters “;” and “#” are not recognized when they appear later in the line.
[databases]
* = host=aux-db.gambit port=5432 user=grafana password=THE_REAL_PASSWORD
[...]
Now, THE_REAL_PASSWORD
is supposed to be secret, I would prefer it if it weren't logged!
If any one else comes across this, just set $QUIET=true
and the config file won't be printed out on startup.
https://github.com/brainsam/pgbouncer/blob/master/entrypoint.sh#L120
@rhefner1 could you close this ticket? if there is no further things to do
@rhefner1 could you close this ticket? if there is no further things to do
@gjcarneiro is the creator of the issue. I can't close it. :)
Well, I would prefer that the container had some conservative security-conscious default behaviour. I shouldn't need to set QUIET env. The default behaviour should be sane.
I see, Im gonna take care of this then, could we trade with the other PR? ;)
https://github.com/brainsam/pgbouncer/pull/28