style-guide icon indicating copy to clipboard operation
style-guide copied to clipboard

Published 20 hours ago • verified publisher icon brainly

Additional margin* props

Open mpacholec opened this issue 5 years ago • 2 comments

<Flex /> component has margin* props with predefined values.

IMHO those should also go to components as Headline & Text etc.

WDYT?

mpacholec avatar Aug 02 '19 13:08 mpacholec

@mpacholec I am not really sure about this solution. I guess it can be achieved by using flex margins. I image you would like to have something like: <p class="sg-text sg-text--margin-left-xs">some text</p>?

burakukula avatar Aug 25 '19 09:08 burakukula

@mpacholec I am not really sure about this solution. I guess it can be achieved by using flex margins. I image you would like to have something like: <p class="sg-text sg-text--margin-left-xs">some text</p>?

Yup that is what I meant. I think it would be nice to have unified margin/padding props across all* components.

e.g.

<Text marginTop="xxs">SOME TEXT</Text>

mpacholec avatar Aug 30 '19 09:08 mpacholec