react-carousel icon indicating copy to clipboard operation
react-carousel copied to clipboard

Support React 17.x

Open mneira10 opened this issue 4 years ago • 11 comments

Hey! Thanks for such a cool library!

Currently, react-carousel supports up to version 16.8.0 of react. It would be awesome if it would support 17.x!

mneira10 avatar Sep 13 '21 23:09 mneira10

May I ask what issues you ran into?

amymorrisonsky avatar Sep 14 '21 13:09 amymorrisonsky

If your project uses React 17, an npm install will fail and only succeed with the --legacy-peer-deps flag as follows:

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @brainhubeu/[email protected]
npm ERR! node_modules/@brainhubeu/react-carousel
npm ERR!   @brainhubeu/react-carousel@"^2.0.4" from the root project

Luckily it works out of the box in React 17. Just annoying that you have to use this dangerous flag for installing it.

m99coder avatar Sep 17 '21 08:09 m99coder

If your project uses React 17, an npm install will fail and only succeed with the --legacy-peer-deps flag as follows:

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @brainhubeu/[email protected]
npm ERR! node_modules/@brainhubeu/react-carousel
npm ERR!   @brainhubeu/react-carousel@"^2.0.4" from the root project

Luckily it works out of the box in React 17. Just annoying that you have to use this dangerous flag for installing it.

I'm facing the same problem :(

mhraihan avatar Sep 18 '21 11:09 mhraihan

If your project uses React 17, an npm install will fail and only succeed with the --legacy-peer-deps flag as follows:

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @brainhubeu/[email protected]
npm ERR! node_modules/@brainhubeu/react-carousel
npm ERR!   @brainhubeu/react-carousel@"^2.0.4" from the root project

Luckily it works out of the box in React 17. Just annoying that you have to use this dangerous flag for installing it.

Good to know! It would be better for the peace of mind to install it without the dangerous flag though

mneira10 avatar Sep 21 '21 19:09 mneira10

If your project uses React 17, an npm install will fail and only succeed with the --legacy-peer-deps flag as follows:

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @brainhubeu/[email protected]
npm ERR! node_modules/@brainhubeu/react-carousel
npm ERR!   @brainhubeu/react-carousel@"^2.0.4" from the root project

Luckily it works out of the box in React 17. Just annoying that you have to use this dangerous flag for installing it.

Same issue here... Please update the dependency configuration.

christian-pletz avatar Oct 11 '21 07:10 christian-pletz

Would be great if react 17 is supported. please update the dependencies.

flokress avatar Oct 11 '21 07:10 flokress

Please support react 17.x

Mixomoda avatar Feb 25 '22 14:02 Mixomoda

Please support react 17.x

yes, please do

edcheyjr avatar Feb 26 '22 20:02 edcheyjr

please

thisKeeWord avatar Mar 26 '22 23:03 thisKeeWord

https://gitmemories.com/sag1v/react-elastic-carousel/issues/235

EduardoNGomes avatar Nov 08 '22 20:11 EduardoNGomes

Here's the patch for React 17-18 https://www.npmjs.com/package/@itseasy21/react-elastic-carousel

and update your imports.

lsilvahbo avatar Jun 12 '23 18:06 lsilvahbo