react-carousel
react-carousel copied to clipboard
brainhubeu
switching to full screen
an ability to show the carousel in the fullscreen
fullScreen option passed to the Carousel component with the following values:
-
null(default) - no fullscreen -
on click- switch to fullscreen on click and switch back on next click -
on double click- switch to fullscreen on double-click and switch back on next double-click -
always- always full screen, it can be used to control fullscreen with a custom way
IssueHunt Summary
Backers (Total: $0.00)
Become a backer now!
Or submit a pull request to get the deposits!
Tips
- Checkout the Issuehunt explorer to discover more funded issues.
- Need some help from other developers? Add your repositories on IssueHunt to raise funds.
@piotr-s-brainhub has funded $11.00 to this issue.
- Submit pull request via IssueHunt to receive this reward.
- Want to contribute? Chip in to this issue via IssueHunt.
- Checkout the IssueHunt Issue Explorer to see more funded issues.
- Need help from developers? Add your repository on IssueHunt to raise funds.
![issuehunt-oss[bot] avatar](https://avatars.githubusercontent.com/in/29881?v=4 "Published by a pub.dev verified publisher"){kind=small}
@piotr-s-brainhub I have a couple of questions regarding to the behavior of the carousel after going fullscreen.
- How should we handle the width and height of the content? Do we keep them at the same size as what they're displaying originally, or should we make them stretch to fix the screen?
Below is the screenshot of the carousel going fullscreen and preserve the content size:
- What is the list of supported browser (minimum versions) for this component?
@huytd
- The size should be increased to fit the entire screen but keeping the image proportions (we have to resize in both directions with the same scale)
- It should work at least for the latest versions of (only desktop):
- Mac: Chrome, Firefox, and Safari
- Windows: Chrome, Firefox, and Edge
@piotr-s-brainhub has funded $1.00 to this issue.
- Submit pull request via IssueHunt to receive this reward.
- Want to contribute? Chip in to this issue via IssueHunt.
- Checkout the IssueHunt Issue Explorer to see more funded issues.
- Need help from developers? Add your repository on IssueHunt to raise funds.
@piotr-s-brainhub has cancelled funding for this issue.(Cancelled amount: $11.00) See it on IssueHunt
@piotr-s-brainhub has cancelled funding for this issue.(Cancelled amount: $1.00) See it on IssueHunt
@piotr-s-brainhub has funded $3.00 to this issue.
- Submit pull request via IssueHunt to receive this reward.
- Want to contribute? Chip in to this issue via IssueHunt.
- Checkout the IssueHunt Issue Explorer to see more funded issues.
- Need help from developers? Add your repository on IssueHunt to raise funds.
@piotr-s-brainhub has funded $3.00 to this issue.
- Submit pull request via IssueHunt to receive this reward.
- Want to contribute? Chip in to this issue via IssueHunt.
- Checkout the IssueHunt Issue Explorer to see more funded issues.
- Need help from developers? Add your repository on IssueHunt to raise funds.
Sorry. Lot’s of stuff is going on from my end and I didn’t have time to follow this yet.
On Mon, Jun 15, 2020 at 4:12 AM piotr-s-brainhub [email protected] wrote:
@huytd https://github.com/huytd would you like to implement this feature?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brainhubeu/react-carousel/issues/322#issuecomment-644064801, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEV4N3SFJ44C4ZPTZEFPGTRWX62LANCNFSM4LFZBR6Q .
@huytd
OK, so I hope somebody else will implement this.
Thanks for your contribution (a question thanks to which we have more details).
@Ckbhatia
I don't know what guide you'd like to have. You can read the workflow and the requirements in this issue description.
@piotr-s-brainhub Where is the directory for this? In the documentation, there's getting started guide for documents. But, I didn't find any guide to get started with react carousel components.
@Ckbhatia
I created https://github.com/brainhubeu/react-carousel/issues/550, I invite you to like (👍) and comment it.
@piotr-s-brainhub has cancelled funding for this issue.(Cancelled amount: $3.00) See it on IssueHunt
@piotr-s-brainhub has cancelled funding for this issue.(Cancelled amount: $3.00) See it on IssueHunt