react-carousel icon indicating copy to clipboard operation
react-carousel copied to clipboard

vertical mode

Open marcindCP opened this issue 6 years ago • 27 comments

Issuehunt badges

Is there any possibility to make carousel vertical?


IssueHunt Summary

Backers (Total: $0.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

marcindCP avatar Nov 26 '19 12:11 marcindCP

Maybe you can try with CSS rotate.

If it's needed for other people as well, maybe we could add such a feature to just pass an option like orientation: 'vertical' or rotation: 90 to react-carousel

piotr-s-brainhub avatar Nov 26 '19 12:11 piotr-s-brainhub

css rotate work for me but drag direction is still horizontal, any idea how to handle this?

marcindCP avatar Nov 26 '19 12:11 marcindCP

it could be because of pageX in https://github.com/brainhubeu/react-carousel/blob/master/src/components/Carousel.js

piotr-s-brainhub avatar Nov 26 '19 12:11 piotr-s-brainhub

if it's possible it would be nice to add feature like vertical: true which will transform: rotate(90deg) and overflow: visibleon BrainhubCarousel class and overflow: visible on BrainhubCarousel__trackContainer class, also set transform: rotate(-90deg) on child. And of course allow vertical scrolling.

marcindCP avatar Nov 26 '19 13:11 marcindCP

@piotr-s-brainhub if this is in scope, i would like to send a pr?

udaypydi avatar Dec 10 '19 23:12 udaypydi

@udaypydi a PR is very welcome

piotr-s-brainhub avatar Dec 10 '19 23:12 piotr-s-brainhub

@piotr-s-brainhub has funded $5.00 to this issue.


issuehunt-oss[bot] avatar Jan 07 '20 13:01 issuehunt-oss[bot]

@udaypydi

Are you going to open a PR, creating the vertical param?

piotr-s-brainhub avatar Jan 21 '20 23:01 piotr-s-brainhub

@piotr-s-brainhub I will take care of this PR.

udaypydi avatar Jan 22 '20 02:01 udaypydi

@udaypydi

I remind you about this.

piotr-s-brainhub avatar Feb 04 '20 19:02 piotr-s-brainhub

@piotr-s-brainhub Looking into this PR today.

udaypydi avatar Feb 04 '20 21:02 udaypydi

@marcindCP @udaypydi

Can I ask you to fill in this form https://docs.google.com/forms/d/1tfRs1Io49tJBwz-06aDnz8hrJ3WySJTi45y4k6hHGaQ ?

piotr-s-brainhub avatar Feb 07 '20 21:02 piotr-s-brainhub

@udaypydi

any progress?

piotr-s-brainhub avatar Mar 20 '20 12:03 piotr-s-brainhub

Hey there, I would like to know the progress of this issue. React-carousel is gonna to have the vertical prop?

LuisFilipePedroso avatar Mar 30 '20 19:03 LuisFilipePedroso

@LuisFilipePedroso it's still in progress, you can check the current state at https://beghp.github.io/gh-pages-rc-4/, adding the vertical prop to any example

@udaypydi are you going to fix the remaining issues to finish the vertical feature or somebody else should finish that?

piotr-s-brainhub avatar Mar 30 '20 20:03 piotr-s-brainhub

@piotr-s-brainhub Need couple of days to fix these. The issues are with basic styling. will wrap them up by tomorrow EOD.

udaypydi avatar Mar 31 '20 17:03 udaypydi

@piotr-s-brainhub has funded $20.00 to this issue.


issuehunt-oss[bot] avatar Mar 31 '20 17:03 issuehunt-oss[bot]

Great, @udaypydi, it will be excellent to have the vertical feature finished. I just increased the funding from 5 USD to 25 USD as it seems to be a critical feature for us.

piotr-s-brainhub avatar Mar 31 '20 17:03 piotr-s-brainhub

@udaypydi

what's the progress? Do you need any help?

piotr-s-brainhub avatar Apr 07 '20 15:04 piotr-s-brainhub

@LuisFilipePedroso

I invite you to like this issue (👍) so more 👍it has, it's more likely to be finished in the nearest time.

piotr-s-brainhub avatar May 14 '20 00:05 piotr-s-brainhub

Has this been integrated yet?

EthanDamien avatar Jul 07 '20 15:07 EthanDamien

When I pass "vertical" it doesn't seem to change the orientation

EthanDamien avatar Jul 07 '20 15:07 EthanDamien

@EthanDamien

Not yet, if it was integrated, this issue would be closed.

We're planning to release this feature in the new major release.

piotr-s-brainhub avatar Jul 07 '20 16:07 piotr-s-brainhub

@piotr-s-brainhub has cancelled funding for this issue.(Cancelled amount: $5.00) See it on IssueHunt

issuehunt-oss[bot] avatar Jul 18 '20 20:07 issuehunt-oss[bot]

@piotr-s-brainhub has cancelled funding for this issue.(Cancelled amount: $20.00) See it on IssueHunt

issuehunt-oss[bot] avatar Jul 18 '20 20:07 issuehunt-oss[bot]

When will this be integrated?

mtShaikh avatar Jun 24 '21 08:06 mtShaikh

@mtShaikh it's unlikely to happen, you'd most certainly find it more useful to look for alternatives to this library or attempting to create your own vertical mode through CSS along with other workarounds.

vaporwavie avatar Jun 29 '21 19:06 vaporwavie