brainflow [WIP] Solving Issue #516

Work in progress. I didn't run any tests at the moment.

The goal of this PR is to solve issue #516 to have multiple streamers for one preset.

Sep 13 '22 10:09 Wameuh

Some comments:

The changes don't take care of if the streamer already exists in the vector. I can handle it if needed but it needs significant modifications.
A test is implemented with Valgrind. But push_package is not tested (I need more understanding about different headers files used, and at the moment push_package is not implemented in the class BoardShim)

Sep 13 '22 13:09 Wameuh

to fix failed clang format job you need to install this and reformat the code https://brainflow.readthedocs.io/en/stable/BrainFlowDev.html#code-style

Sep 13 '22 21:09 Andrey1994

at the first sight looks fine, just need to fix test a little. And more important you need to add this test to CI pipelines, need to add new entry to valgrind.yml(I sent a link to it) Here you can find info about CI used https://docs.github.com/en/actions/learn-github-actions/understanding-github-actions in brainflow

Thanks. That's my bad, I added the test in the valgrind.yml but forgot to add it in the commit. I will do it in the next commit.

Sep 14 '22 06:09 Wameuh