brainflow icon indicating copy to clipboard operation
brainflow copied to clipboard

Add JS binding

Open Andrey1994 opened this issue 5 years ago • 1 comments

Andrey1994 avatar Nov 01 '20 12:11 Andrey1994

Stale issue, need to tale a look

github-actions[bot] avatar Jan 01 '21 00:01 github-actions[bot]

bump

dman2210 avatar May 05 '23 19:05 dman2210

Hello guys,

I started working on it locally. Keep you posted

GordonPmnt avatar Jul 10 '23 21:07 GordonPmnt

Is there any kanban view or board somewhere? I'd like to put this in progress.

Already wrotte a part of the board-shim. My goal is to do it by the end of the year (cannot go very quick because I don't have much time), but definitely doing it.

Should I open a wip PR somewhere to show progress?

GordonPmnt avatar Jul 13 '23 12:07 GordonPmnt

Wip pr will be good also I will be able to help then.

And we have no boards to track tasks

Andrey1994 avatar Jul 13 '23 12:07 Andrey1994

I might be able to pitch in here. Any progress? @GordonPmnt

dman2210 avatar Jul 18 '23 21:07 dman2210

I might be able to pitch in here. Any progress?

Actually yes @dman2210 . I did a good part of the board-shim and I started the data-filters.

I'm going to create a PR but for this I firstly need to find a good example to create a TS and JS package for brainflow. I'm not the king of webpack so I postponed a bit. If you have any available boilerplate, might help actually.

Here is a screenshot of a test I did with electron.js. Started a session with synthetic board, recorded 5 secs and did log the first channel. image

GordonPmnt avatar Jul 18 '23 22:07 GordonPmnt

Is webpack necessary?

If so I am told these are good biolerplates to pull from for javascript webpack. https://github.com/erikras/react-redux-universal-hot-example/blob/master/webpack/prod.config.js https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/main/examples/webpack-plugin-serve/webpack.config.js

Here are some package.json files as well for javascript.

https://github.com/erikras/react-redux-universal-hot-example/blob/master/package.json https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/main/package.json https://github.com/firebase/firebase-js-sdk/blob/master/packages/app/package.json

This article had a very simple webpack boilerplate for typescript.

https://blog.logrocket.com/using-webpack-typescript/

dman2210 avatar Jul 18 '23 22:07 dman2210

Hello @dman2210 @Andrey1994

This is here, I did put an example with the boardshim class: https://github.com/brainflow-dev/brainflow/pull/646/files

Right now, you can try it running the command yarn run example (you'll have to copy paste yourself the dll file in the lib repo though. I haven't updated any scripts yet.

GordonPmnt avatar Jul 20 '23 00:07 GordonPmnt

Hi @GordonPmnt! Great progress, I will take a look

Andrey1994 avatar Jul 23 '23 23:07 Andrey1994