braindecode icon indicating copy to clipboard operation
braindecode copied to clipboard

Preserve order when splitting datasets

Open gemeinl opened this issue 4 years ago • 1 comments

Splitting of datasets (https://github.com/braindecode/braindecode/blob/master/braindecode/datasets/base.py#L160-L162) should probably return an OrderedDict. For example, if data is split for subjects or enumerated runs, then iterating through the returned dictionary should contain data of subject or runs in ascending order.

gemeinl avatar Sep 30 '20 13:09 gemeinl

Please check if this is even necessary with current Python Version

robintibor avatar Jun 15 '21 12:06 robintibor

Hi @robintibor and @gemeinl, I performed some tests and the order is being preserved in the split.

bruAristimunha avatar Sep 05 '22 02:09 bruAristimunha

great

robintibor avatar Sep 07 '22 13:09 robintibor