DPP icon indicating copy to clipboard operation
DPP copied to clipboard

Published 20 hours ago • verified publisher icon brainboxdotcc

Unit test tidyup

Open braindigitalis opened this issue 10 months ago • 11 comments

test.cpp and friends are large and unwieldy. it is now over 2000 lines, this is 🤢 - as a small project this could do with tidying up and breaking down into smaller files. anything under the unittest folder will be linked into one executable.

This is an ideal first issue for an intermediate developer wanting to contribute to D++.

braindigitalis avatar Oct 10 '23 12:10 braindigitalis

#948 introduced crases and caused unit tests to fail:

coro: offline job                                            FAIL
coro: offline coroutine                                      FAIL
coro: offline task                                           FAIL
coro: offline async                                          FAIL
coro: online event handler                                   PASS
coro: online api calls                                       PASS
coro: online mumbo jumbo in event handler                    SKIPPED

Execution finished in 55.809 seconds.
Failed: 4 Passed: 138 Skipped: 19 Percentage: 97.18%
terminate called after throwing an instance of 'std::system_error'
  what():  Invalid argument
Aborted (core dumped)

As such this breaks CI so we had to roll it back. Anyone welcome to try again but we must make sure that it doesnt break the tests.

The failing tests are skipped when ran as part of a PR (you dont have access to the token) but when it is merged into dev the online tests are ran. This was not tested with a token with the online tests before submitting the PR.

braindigitalis avatar Oct 22 '23 13:10 braindigitalis

This is still open if anyone wants to take this!

Jaskowicz1 avatar Nov 05 '23 18:11 Jaskowicz1

Gonna take this on myself. I will be basing it off #948 as we agreed that the format was good.

Jaskowicz1 avatar Nov 14 '23 20:11 Jaskowicz1

I'd put this off for a bit as I faced issues with Mac and whatnot, will look to maybe pick this up over Christmas if no-one else does (as I am busy until then).

Jaskowicz1 avatar Nov 22 '23 10:11 Jaskowicz1

This issue has had no activity and is being marked as stale. If you still wish to continue with this issue please comment to reopen it.

github-actions[bot] avatar Jan 22 '24 02:01 github-actions[bot]

Reminder, we're looking for people to complete this project! I'll post this in the Discord too!

Jaskowicz1 avatar Jan 25 '24 11:01 Jaskowicz1

Hello @Jaskowicz1, I would like to work on this issue, is it still open?

mayankag32 avatar Feb 10 '24 18:02 mayankag32

sure feel free to grab it, please do not add any external dependencies such as catch2!

braindigitalis avatar Feb 10 '24 21:02 braindigitalis

Going to actually take this on myself this time.

Jaskowicz1 avatar Feb 19 '24 16:02 Jaskowicz1

This issue has had no activity and is being marked as stale. If you still wish to continue with this issue please comment to reopen it.

github-actions[bot] avatar Jun 04 '24 02:06 github-actions[bot]

Bump

Mishura4 avatar Jun 04 '24 02:06 Mishura4

This issue has had no activity and is being marked as stale. If you still wish to continue with this issue please comment to reopen it.

github-actions[bot] avatar Aug 04 '24 02:08 github-actions[bot]