DPP icon indicating copy to clipboard operation
DPP copied to clipboard

Published 20 hours ago • verified publisher icon brainboxdotcc

std::basic_string<uint8_t> is broken for LLVM-19

Open ghost opened this issue 1 year ago • 9 comments
trafficstars

Describe the bug The uint8_t type is typedef'ed as unsigned char in glibc. However the support for unsigned char type has been removed from std::char_traits in libc++ according to https://reviews.llvm.org/D138307. This gives an "implicit instantiation of undefined template std::char_traits<unsigned char>" error, during build.

To Reproduce Steps to reproduce the behavior:

  1. Compile D++ using the latest libc++.

System Details:

  • OS: Linux

Additional context I would like to know what could be the proposed fix for this? I wouldn't mind sending the PR.

ghost avatar Apr 16 '24 11:04 ghost

what thing in dpp actually causes the warning, under what compiler and version?

braindigitalis avatar Apr 16 '24 11:04 braindigitalis

It's on this line https://github.com/brainboxdotcc/DPP/blob/89b43ba1445f99114f1c583529d01ad210918c35/include/dpp/dispatcher.h#L2016. The compiler is Clang 19.

ghost avatar Apr 16 '24 12:04 ghost

I'm not sure this needs to be a string, perhaps a vector would suffice? it is important for it to be unsigned 8 bit wide elements though.

braindigitalis avatar Apr 16 '24 17:04 braindigitalis

Yeah, I agree.

ghost avatar Apr 16 '24 17:04 ghost

Any news on this?

Jaskowicz1 avatar May 13 '24 19:05 Jaskowicz1

Idk we just need to have someone pick this up

Mishura4 avatar May 13 '24 19:05 Mishura4

I can look into this next week

Mishura4 avatar May 22 '24 21:05 Mishura4

I can look into this next week

image

Jaskowicz1 avatar Jun 09 '24 16:06 Jaskowicz1

No unfortunately I just got extremely busy 😔

Mishura4 avatar Jun 09 '24 17:06 Mishura4

I think we should close this issue.

ruslan-ilesik avatar Jul 09 '24 21:07 ruslan-ilesik