caspion icon indicating copy to clipboard operation
caspion copied to clipboard

Switch UI to react WIP

Open brafdlog opened this issue 4 years ago • 4 comments

  • [x] Unify react wip flow into repo
  • [x] Linting errors
  • [x] Allow running react version side by side with vue version to allow merging before full feature parity
  • [ ] Implement all flows
    • [x] Importers create/update/delete
    • [x] Importers enable/disable
    • [ ] Exporter settings
      • [x] Excel
      • [x] JSON
      • [ ] Ynab
      • [ ] Google sheets
    • [x] General settings (num scraping days and show browser)

Maybe in a separate PR:

  • [ ] Improve UX to match design
  • [ ] Solve ynap api issue and remove disabling of https check
  • [ ] Error reporting (sentry)
  • [ ] Analytics
  • [ ] Download Chrome progress
  • [ ] Remove vue
  • [ ] Check for updates flow
  • [ ] Monorepo
    • [ ] Separate to worskpaces (yarn workspaces? with lerna)?
    • [ ] Solve react dependency issue and remove SKIP_PREFLIGHT_CHECK hack

brafdlog avatar Oct 22 '21 13:10 brafdlog

Will provide a script to run both easily

brafdlog avatar Oct 22 '21 13:10 brafdlog

I don't think we have to match to the design. I think we need to focus on supporting the same functionality as before.

Any improvments can be done by other PRs. We have to break the change.

baruchiro avatar Nov 01 '21 20:11 baruchiro

Added the option to switch between the vew and react ui so we won't have to wait for full feature parity in order to merge. I think I will add the ynab settings implementation and then want to merge (defaulting the ui to the old implementation but allowing to switch). @baruchiro WDYT? (Ignore the redness of the screenshots, that is not how it looks)

image

image

brafdlog avatar Mar 25 '22 21:03 brafdlog

@brafdlog Yes, I think it is the best option. Once it will be merged we will be able to do small changes, and also contributors will see their effect.

baruchiro avatar Mar 31 '22 10:03 baruchiro

@baruchiro there are more things I want to add but since this allows the option of switching between old and new UI I don't think we should wait any longer. Would love to get your feedback

brafdlog avatar Oct 11 '22 08:10 brafdlog

* What about keep the Vue UI as default?

I know the e2e tests are not so useful, but they are what we have. I think keeping the Vue as default will ignore the tests problem, for now, see if you prefer to solve the issue or avoid it for now.

baruchiro avatar Oct 16 '22 13:10 baruchiro

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Oct 21 '22 05:10 github-actions[bot]